Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support passing encode argument for RequestSetLiveStreamMode #604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TinfoilSubmarine
Copy link
Contributor

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Does this pull request reference an issue (i.e. bug or enhancement)? If not, you should probably create one. If it is a very simple / small change, this is not needed and just describe the issue below.
  • Make sure to link this pull request to the issue after the pull request is created.
  • Anyone can review this but make sure to add at least one administrator (anyone who can be found under Reviewers)
  • Make sure to add necessary documentation (if appropriate)
  • Once the pull request is created, ensure that the pre-merge checks all run succesfully.
  • If you add a file that requires copyright updates, this will be automatically done via pre-merge checks and pushed to your branch.

Description

This enables passing --encode | --no-encode to livestream.py, defaulting (as before) to True:

$ python3 livestream.py -h                                                             main 
usage: livestream.py [-h] [--min_bit MIN_BIT] [--max_bit MAX_BIT] [--start_bit START_BIT] [--resolution {4,7,12}]
                     [--fov {0,4,3}] [--encode | --no-encode] [--log LOG] [--identifier IDENTIFIER]
                     ssid password url

Connect to the GoPro via BLE only, configure then start a Livestream, then display it with CV2.

positional arguments:
  ssid                  WiFi SSID to connect to.
  password              Password of WiFi SSID.
  url                   RTMP server URL to stream to.

options:
  -h, --help            show this help message and exit
  --min_bit MIN_BIT     Minimum bitrate.
  --max_bit MAX_BIT     Maximum bitrate.
  --start_bit START_BIT
                        Starting bitrate.
  --resolution {4,7,12}
                        Resolution.
  --fov {0,4,3}         Field of View.
  --encode, --no-encode
                        Save video to sdcard.
  --log LOG             Location to store detailed log
  --identifier IDENTIFIER
                        Last 4 digits of GoPro serial number, which is the last 4 digits of the default camera SSID.
                        If not used, first discovered GoPro will be connected to
                        ```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant