Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type of resolution CLI flag #595

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix type of resolution CLI flag #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions demos/python/sdk_wireless_camera_control/open_gopro/demos/gui/livestream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,12 @@ def parse_arguments() -> argparse.Namespace:
parser.add_argument("--min_bit", type=int, help="Minimum bitrate.", default=1000)
parser.add_argument("--max_bit", type=int, help="Maximum bitrate.", default=1000)
parser.add_argument("--start_bit", type=int, help="Starting bitrate.", default=1000)
parser.add_argument("--resolution", help="Resolution.", choices=list(proto.EnumWindowSize.values()), default=None)
parser.add_argument("--fov", help="Field of View.", choices=list(proto.EnumLens.values()), default=None)
parser.add_argument(
TinfoilSubmarine marked this conversation as resolved.
Show resolved Hide resolved
"--resolution", help="Resolution.", choices=list(proto.EnumWindowSize.values()), default=None, type=int # type: ignore
)
parser.add_argument(
"--fov", help="Field of View.", choices=list(proto.EnumLens.values()), default=None, type=int # type: ignore
)
return add_cli_args_and_parse(parser, wifi=False)


Expand Down