Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose "raw":"1" from the API in MediaList #586

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Expose "raw":"1" from the API in MediaList #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d52bde9
Expose raw flag on media list, so a separate metadata request is not …
autopulated Aug 22, 2024
46b21c8
Add test for raw flag from media list.
autopulated Aug 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demos/python/sdk_wireless_camera_control/open_gopro/models/media_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ class MediaItem(CustomBaseModel):
low_res_video_size: Optional[str] = Field(alias="glrv", default=None) #: Low resolution video size
lrv_file_size: Optional[str] = Field(alias="ls", default=None) #: Low resolution file size
session_id: Optional[str] = Field(alias="id", default=None) # Media list session identifier
raw: Optional[str] = Field(default=None) #: 1 if photo has raw version, 0 (or omitted) otherwise


class GroupedMediaItem(MediaItem):
Expand Down
4 changes: 3 additions & 1 deletion demos/python/sdk_wireless_camera_control/tests/unit/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@
"ls": "-1",
"s": "25086075",
},
{"n": "GOPR0039.JPG", "cre": "1724339068", "mod": "1724339068", "raw": "1", "s": "783927"},
],
}
],
Expand All @@ -134,9 +135,10 @@ def test_media_list():
media_list = MediaList(**MEDIA_LIST)
assert media_list
items = media_list.files
assert len(items) == 12
assert len(items) == 13
assert len([item for item in items if isinstance(item, GroupedMediaItem)]) == 2
assert media_list.files[0].filename == "100GOPRO/GX010001.MP4"
assert media_list.files[-1].raw == "1"


VIDEO_METADATA: Final = {
Expand Down