Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add setting 125 #560

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add setting 125 #560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ed4082
Add setting 125 to Python SDK
tcamise-gpsw Jul 1, 2024
9a052d0
Update changelog
tcamise-gpsw Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions demos/python/sdk_wireless_camera_control/docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file.
The format is based on `Keep a Changelog <https://keepachangelog.com/en/1.0.0/>`_,
and this project adheres to `Semantic Versioning <https://semver.org/spec/v2.0.0.html>`_.

Unreleased
----------

* Add Setting 125

0.16.1 (April-23-2024)
----------------------

Expand Down
9 changes: 9 additions & 0 deletions demos/python/sdk_wireless_camera_control/open_gopro/api/ble_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1073,6 +1073,15 @@ def __init__(self, communicator: GoProBle):

super().__init__(communicator)

self.photo_output: BleSetting[Params.PhotoOutput] = BleSetting[Params.PhotoOutput](
communicator,
SettingId.PHOTO_OUTPUT,
Params.PhotoOutput,
)
"""File type of photo output"""

super().__init__(communicator)


class BleAsyncResponses:
"""These are responses whose ID's are not associated with any messages"""
Expand Down
6 changes: 6 additions & 0 deletions demos/python/sdk_wireless_camera_control/open_gopro/api/http_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,4 +727,10 @@ def __init__(self, communicator: GoProHttp):
)
"""Interval between photo captures"""

self.photo_output: HttpSetting[Params.PhotoOutput] = HttpSetting[Params.PhotoOutput](
communicator,
SettingId.PHOTO_OUTPUT,
)
"""File type of photo output"""

super().__init__(communicator)
7 changes: 7 additions & 0 deletions demos/python/sdk_wireless_camera_control/open_gopro/api/params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,13 @@ class PhotoDuration(GoProIntEnum):
HOUR_3 = 9


class PhotoOutput(GoProIntEnum):
STANDARD = 0
RAW = 1
HDR = 2
SUPERPHOTO = 3


class PresetGroup(GoProIntEnum):
VIDEO = 1000
PHOTO = 1001
Expand Down
2 changes: 1 addition & 1 deletion demos/python/sdk_wireless_camera_control/open_gopro/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ class SettingId(GoProIntEnum):
PHOTO_FOV = 122
MULTI_SHOT_FOV = 123
INTERNAL_124 = 124
INTERNAL_125 = 125
PHOTO_OUTPUT = 125
INTERNAL_126 = 126
MEDIA_FORMAT = 128
INTERNAL_129 = 129
Expand Down