Only ask for sudo password when required #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check nmcli permissions and only ask for password if required. Move getpass to separate func and validate password input using assert Otherwise raise AssertionError Change sudo func to return an empty string if no sudo password is provided in order to prevent formating of the nmcli commands with sudo prefix if not required. Raise condition is moved at password input.
As password isn't a mandatory requirement for the follwing classes also accept None type arg for password. - Nmcli0990Wireless - NmcliWireless - WpasupplicantWireless Replace assert with if not raise RunTime error.
tcamise-gpsw
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #483
Check nmcli permissions and only ask for password if required.
Move getpass to separate func and validate password input, Otherwise raise RuntimeError
Change sudo func to return an empty string if no sudo password is provided in order to prevent formatting of the nmcli commands with sudo prefix if not required.
Raise condition is moved at password input using assert.