Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate version call in wired gopro #444

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove duplicate version call in wired gopro #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions demos/python/sdk_wireless_camera_control/docs/changelog.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Unreleased
* Add alpha support for COHN (Camera-on-the-Home-Network)
* A real implementation is going to require a major rearchitecture to dynamically add connection types.
* Remove TKinter GUI. Will be replaced with Textual TUI in the future
* Improve wifi SSID matching

0.14.1 (September-21-2022)
--------------------------
Expand Down
1 change: 0 additions & 1 deletion demos/python/sdk_wireless_camera_control/open_gopro/gopro_wired.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ async def open(self, timeout: int = 10, retries: int = 1) -> None:

await self.http_command.wired_usb_control(control=Params.Toggle.ENABLE)
# Find and configure API version
version = await self.http_command.get_open_gopro_api_version()
if (version := (await self.http_command.get_open_gopro_api_version()).data) != self.version:
raise GpException.InvalidOpenGoProVersion(version)
logger.info(f"Using Open GoPro API version {version}")
Expand Down
2 changes: 1 addition & 1 deletion demos/python/sdk_wireless_camera_control/open_gopro/wifi/adapters/wireless.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ def connect(self, ssid: str, password: str, timeout: float = 15) -> bool:
r"/System/Library/PrivateFrameworks/Apple80211.framework/Versions/Current/Resources/airport --scan"
)
lines = response.splitlines()
ssid_end_index = lines[0].index("SSID") + 4 # Find where the SSID column ends
ssid_end_index = lines[0].index("SSID") + 4 # Find where the SSID column ends

for result in lines[1:]: # Skip title row
current_ssid = result[:ssid_end_index].strip()
Expand Down
Loading