Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use "length" over "len" in tutorial3 python #425

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

alestiago
Copy link
Contributor

Description

Edit the occurrence of "len" to "length" since the ble_command_get_version.py that is being referenced uses "length".

See permalink:

@alestiago alestiago marked this pull request as draft October 26, 2023 20:51
@alestiago alestiago marked this pull request as ready for review October 26, 2023 20:53
@alestiago
Copy link
Contributor Author

alestiago commented Oct 26, 2023

@tcamise-gpsw , first of all thank you for maintaining this repository.

This is a simple Pull Request, when I was reading through the tutorials I noticed this mismatch between the variable names in the docs and those in the tutorial (demo).

The CI seems to be failing on the "Pre Merge Checks", if there is something I need to do on my end let me know. Feel free to close or amend yourself.

Once again, thank you for maintaining this and I hope to see GoPro get more involved in OSS.

@tcamise-gpsw tcamise-gpsw merged commit 8bb39a3 into gopro:main Dec 7, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants