Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python SDK - improve wifi SSID matching (#378) #413

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

Nikolas-S
Copy link
Contributor

@Nikolas-S Nikolas-S commented Oct 2, 2023

  • Does this pull request reference an issue (i.e. bug or enhancement)? If not, you should probably create one. If it is a very simple / small change, this is not needed and just describe the issue below.
  • Make sure to link this pull request to the issue after the pull request is created.
  • Anyone can review this but make sure to add at least one administrator (anyone who can be found under Reviewers)
  • Make sure to add necessary documentation (if appropriate)
  • Once the pull request is created, ensure that the pre-merge checks all run succesfully.
  • If you add a file that requires copyright updates, this will be automatically done via pre-merge checks and pushed to your branch.

Description

Fixes #378
Improves Wifi SSID matching when connecting to a GoPro to allow for spaces in the SSID.
Adding the "-f SSID" option to nmcli changes its output to only show the SSID column.
Regarding MacOS, airport formats its output in columns such that the ends of all SSIDs align with the end of the "SSID" column label, which can be (ab)used for parsing. I was able to find screenshots from as far back as 2012 which display this behaviour, and my current machine running MacOS 13.4.1 also behaves like this, though I can't say for certain that every version formats its output like this.

@tcamise-gpsw
Copy link
Collaborator

CI is apparently not setup for merges from forked repos.
Anyway I'll merge this then deal with any related updates in my coming PR's

@tcamise-gpsw tcamise-gpsw merged commit c1a8d23 into gopro:main Dec 6, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPI with Bullseye OS - wifi scan timed out
2 participants