Add setting 125 (#560)

gopro · Jul 1, 2024 · e88082f · e88082f
1 parent 9d516c4
commit e88082f
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 1 deletion.
diff --git a/demos/python/sdk_wireless_camera_control/docs/changelog.rst b/demos/python/sdk_wireless_camera_control/docs/changelog.rst
@@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file.
 The format is based on `Keep a Changelog <https://keepachangelog.com/en/1.0.0/>`_,
 and this project adheres to `Semantic Versioning <https://semver.org/spec/v2.0.0.html>`_.
 
+Unreleased
+----------
+
+* Add Setting 125
+
 0.16.1 (April-23-2024)
 ----------------------
 

diff --git a/demos/python/sdk_wireless_camera_control/open_gopro/api/ble_commands.py b/demos/python/sdk_wireless_camera_control/open_gopro/api/ble_commands.py
@@ -1073,6 +1073,15 @@ def __init__(self, communicator: GoProBle):
 
         super().__init__(communicator)
 
+        self.photo_output: BleSetting[Params.PhotoOutput] = BleSetting[Params.PhotoOutput](
+            communicator,
+            SettingId.PHOTO_OUTPUT,
+            Params.PhotoOutput,
+        )
+        """File type of photo output"""
+
+        super().__init__(communicator)
+
 
 class BleAsyncResponses:
     """These are responses whose ID's are not associated with any messages"""

diff --git a/demos/python/sdk_wireless_camera_control/open_gopro/api/http_commands.py b/demos/python/sdk_wireless_camera_control/open_gopro/api/http_commands.py
@@ -727,4 +727,10 @@ def __init__(self, communicator: GoProHttp):
         )
         """Interval between photo captures"""
 
+        self.photo_output: HttpSetting[Params.PhotoOutput] = HttpSetting[Params.PhotoOutput](
+            communicator,
+            SettingId.PHOTO_OUTPUT,
+        )
+        """File type of photo output"""
+
         super().__init__(communicator)
diff --git a/demos/python/sdk_wireless_camera_control/open_gopro/api/params.py b/demos/python/sdk_wireless_camera_control/open_gopro/api/params.py
@@ -423,6 +423,13 @@ class PhotoDuration(GoProIntEnum):
     HOUR_3 = 9
 
 
+class PhotoOutput(GoProIntEnum):
+    STANDARD = 0
+    RAW = 1
+    HDR = 2
+    SUPERPHOTO = 3
+
+
 class PresetGroup(GoProIntEnum):
     VIDEO = 1000
     PHOTO = 1001

diff --git a/demos/python/sdk_wireless_camera_control/open_gopro/constants.py b/demos/python/sdk_wireless_camera_control/open_gopro/constants.py
@@ -202,7 +202,7 @@ class SettingId(GoProIntEnum):
     PHOTO_FOV = 122
     MULTI_SHOT_FOV = 123
     INTERNAL_124 = 124
-    INTERNAL_125 = 125
+    PHOTO_OUTPUT = 125
     INTERNAL_126 = 126
     MEDIA_FORMAT = 128
     INTERNAL_129 = 129