Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom elements CodeChange & CodeBlock for MarkdownView #1183

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Custom elements CodeChange & CodeBlock for MarkdownView #1183

merged 2 commits into from
Dec 28, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Dec 27, 2024 •
edited
Loading

@qiniu-prow qiniu-prow
Copy link

qiniu-prow bot commented Dec 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@nighca nighca requested a review from Copilot December 27, 2024 09:41
nighca
nighca commented Dec 27, 2024
View reviewed changes
spx-backend/internal/controller/copilot.go Outdated
Messages: anthropic.F(messages),
System: anthropic.Raw[[]anthropic.TextBlockParam](copilot.SystemPrompt),
Messages: anthropic.F(messages),
Temperature: anthropic.F(0.5),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发现默认是 1，感觉不太适合，先取个 0.5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉 0.5 会不会也有点高？代码生成、解释类场景取 <= 0.3 也许会合适点，我看我 neovim 用的 github copilot 插件默认设置的是 0.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯有道理，我先改成 0.3 吧

Copilot
Copilot AI reviewed Dec 27, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • spx-gui/src/components/editor/code-editor/ui/markdown/common/BlockFooter.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/MarkdownView.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/definition/DefinitionDetail.vue: Evaluated as low risk
  • spx-gui/src/components/ui/UIConfigProvider.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/definition/DefinitionOverviewWrapper.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/common/BlockWrapper.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/api-reference/APIReferenceItem.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/CodeBlock.vue: Evaluated as low risk
  • spx-gui/src/components/ui/UIIconButton.vue: Evaluated as low risk
  • spx-gui/src/components/ui/UIButton.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/common/BlockActionBtn.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/CodeChange.vue: Evaluated as low risk
  • spx-gui/src/components/editor/code-editor/ui/markdown/CodeView.vue: Evaluated as low risk
  • spx-backend/internal/copilot/prompt.go: Evaluated as low risk
  • spx-backend/internal/copilot/custom_element_code_link.md: Evaluated as low risk
nighca
nighca commented Dec 27, 2024
View reviewed changes
spx-backend/internal/copilot/system_prompt.md
@@ -12,9 +12,15 @@
</document_content>
</document>
<document>
<source>custom-elements.md</source>
<source>custom-element-code-link.md</source>
Copy link
Collaborator Author

@nighca nighca Dec 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

发现把多个 element 的文档合在同一个 md 文件里的话，模型容易混淆不同 element 的用法

@nighca nighca marked this pull request as ready for review December 27, 2024 09:45
aofei
aofei approved these changes Dec 27, 2024
View reviewed changes
spx-backend/internal/controller/copilot.go Outdated
Messages: anthropic.F(messages),
System: anthropic.Raw[[]anthropic.TextBlockParam](copilot.SystemPrompt),
Messages: anthropic.F(messages),
Temperature: anthropic.F(0.5),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉 0.5 会不会也有点高？代码生成、解释类场景取 <= 0.3 也许会合适点，我看我 neovim 用的 github copilot 插件默认设置的是 0.1

@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@nighca nighca merged commit 66e6e74 into goplus:dev Dec 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@aofei aofei aofei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Component CodeChange
3 participants
@nighca @qiniu-ci @aofei