[CLEANUP] Replace experimental maps and slices with stdlib
#2993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The experimental functions are now available in the standard library in Go 1.23 [1]. [1]: https://go.dev/doc/go1.23#new-unique-package Signed-off-by: Eng Zer Jun <[email protected]>
AnomalRoil
reviewed
Nov 6, 2024
Comment on lines
+99
to
+101
| return slices.SortedFunc(bes, func(a, b V) int { | ||
| return cmp.Compare(a.Priority(), b.Priority()) | ||
| }) |
There was a problem hiding this comment.
Why can't you use slices.Sorted directly? I'd expect Priority() to return a cmp.Ordered value, no?
There was a problem hiding this comment.
We can't use slices.Sorted.
You can see the types permitted by cmp.Ordered here: https://pkg.go.dev/cmp#Ordered. We are using generics so it is not possible to use slices.Sorted here.
Comment on lines
+345
to
+346
| _, ok := c.vars["core.sshCommand"] | ||
| assert.True(t, ok) |
There was a problem hiding this comment.
The old code
assert.Contains(t, maps.Keys(c.vars), "core.sshCommand")was just testing whether the core.sshCommand key exists in the c.vars map or not.
Obviously we can do assert.Contains(t, set.SortedKeys(c.vars), "core.sshCommand") too to test whether core.sshCommand exists in c.vars or not. But _, ok := c.vars["core.sshCommand"] does the job in a much simplier way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The experimental functions are now available in the standard library in Go 1.23 1.
The only difference is that
maps.Keysandmaps.Valuesin the standard library return an iterator, whilemaps.Keysandmaps.Valuesin thegolang.org/x/exppackage return a slice.Footnotes
https://go.dev/doc/go1.23#new-unique-package ↩