Steam TOTP support #2980
Steam TOTP support #2980
Conversation
|
Related to #2566 |
| @@ -2,6 +2,8 @@ module github.com/gopasspw/gopass | |||
|
|
|||
| go 1.23.2 | |||
|
|
|||
| replace github.com/pquerna/otp => github.com/nikicat/otp v1.4.0-ojo | |||
There was a problem hiding this comment.
This would be too much of a supply chain attack risk, and also replace statement in a go.mod aren't meant to be shipped in a library, and some bits of gopass are acting as a library, so not great.
Any chance you could upstream that to pquerna/otp or provide the derivation in our code directly?
We're trying to generally reduce the number of dependencies, not add new ones.
There was a problem hiding this comment.
I'll try to merge this change upstream, that's why I've created a draft PR. I think conversion from a standard digital code format is possible, but is a bit hacky, as it needs to requires at least 8 digits code to be requested and then reencoded to Steam's base26 format.
There was a problem hiding this comment.
Yeah, sorry I fat fingered the undraft button when trying to authorize the Github Action
This PR adds Steam TOTP encoding support. totp:// url should contain
encoding=steamquery parameter.