Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(backend): add unit tests for Registry #2974

Merged
merged 1 commit into from
Oct 20, 2024
Merged

test(backend): add unit tests for Registry #2974

merged 1 commit into from
Oct 20, 2024

Conversation

Juneezee
Copy link
Contributor

Improve test coverage and validate the behavior of

  1. Registry.BackendNames()
  2. Registry.Backends()
  3. Registry.Prioritized()
  4. Registry.Get(key K)
  5. Registry.Backend(name string)
  6. Registry.BackendName(backend K)

AnomalRoil
AnomalRoil approved these changes Oct 19, 2024
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

dominikschulz
dominikschulz approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dominikschulz dominikschulz merged commit 638e577 into gopasspw:master Oct 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil approved these changes

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juneezee @dominikschulz @AnomalRoil