Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Copy with trailing slash at destination. #2966

Merged
merged 2 commits into from
Oct 11, 2024
Merged

[bugfix] Copy with trailing slash at destination. #2966

merged 2 commits into from
Oct 11, 2024

Conversation

vijay-kesanakurthi
Copy link
Contributor

FIxes #2912

dominikschulz
dominikschulz reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks great. Clean and descriptive. But I was wondering if you could at least add one test case for the new / changed behaviour?

@vijay-kesanakurthi
Copy link
Contributor Author

I have added a test , could you check and give feedback if any changes needed?

dominikschulz
dominikschulz approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dominikschulz dominikschulz merged commit a5be685 into gopasspw:master Oct 11, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gopass cp has a different behaviour depending on whether the recursive directory already exist
2 participants
@vijay-kesanakurthi @dominikschulz