Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a global nosync option to turn off auto-sync #2626

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

dominikschulz
Copy link
Member

This is mainly intended for tests or other restricted environments. Regular users should prefer the core.autosync option in the config.

Fixes #2616

This is mainly intended for tests or other restricted environments.
Regular users should prefer the core.autosync option in the config.

Fixes gopasspw#2616

Signed-off-by: Dominik Schulz <[email protected]>
@dominikschulz dominikschulz added the cleanup Code hygiene label Jul 30, 2023
@dominikschulz dominikschulz added this to the 1.15.6 milestone Jul 30, 2023
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -52,6 +52,10 @@ func ShowFlags() []cli.Flag {
Aliases: []string{"n"},
Usage: "Do not parse the output.",
},
&cli.BoolFlag{
Name: "nosync",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about also setting a
EnvVar
for it since the goal is to help usage in CI/CD or in scripts? IIRC cli Flags support it out of the box

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we'd have yet another way to set config options (I don't think we're using EnvVars, yet).
I'd rather not do that. At least not right here/now.

@dominikschulz dominikschulz merged commit 45aca2a into gopasspw:master Jul 30, 2023
7 of 8 checks passed
@dominikschulz dominikschulz deleted the fix/issue-2616 branch July 30, 2023 16:58
christian-heusel added a commit to christian-heusel/dotfiles that referenced this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code hygiene
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make gopass sync optional
2 participants