Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitfs: support git submodules #2606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

0x450x6c
Copy link

@0x450x6c 0x450x6c commented Jun 15, 2023

Hello.

I use git submodule as a store, and gopass didn't recognize it as a git repo.

With this change gopass can recognize git submodules as a repository, so gopass sync works. (tested locally)

@dominikschulz
Copy link
Member

Oh my, I don't like git submodules. The UX is terrible. Let me see how much complexity this would add ...

@dominikschulz dominikschulz added the feature Enhancements and new features label Jun 16, 2023
@dominikschulz dominikschulz added this to the 1.x.x milestone Jun 16, 2023
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay. The code itself looks fine, but we need two things before we can merge it:

  1. Comments, explaining what is happening. I'm not deeply familiar with submodules and some explanation is necessary to make sense of this.
  2. Tests, showing and validating the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants