Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENHANCEMENT] Added FreeBSD support #126

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[ENHANCEMENT] Added FreeBSD support #126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e766aac
[ENHANCEMENT] Added FreeBSD support
Jun 27, 2024
d8a7f86
Update internal/jsonapi/manifest/manifest_path_others.go
b100w11 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ crosscompile:
@echo -n ">> CROSSCOMPILE darwin/amd64"
@GOOS=darwin GOARCH=amd64 $(GO) build -o $(GOPASS_OUTPUT)-darwin-amd64
@printf '%s\n' '$(OK)'
@echo -n ">> CROSSCOMPILE freebsd/amd64"
@GOOS=freebsd GOARCH=amd64 $(GO) build -o $(GOPASS_OUTPUT)-freebsd-amd64
@printf '%s\n' '$(OK)'
@echo -n ">> CROSSCOMPILE windows/amd64"
@GOOS=windows GOARCH=amd64 $(GO) build -o $(GOPASS_OUTPUT)-windows-amd64
@printf '%s\n' '$(OK)'
Expand Down
22 changes: 22 additions & 0 deletions internal/jsonapi/manifest/manifest_path_freebsd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
package manifest

var manifestPaths = &manifestPath{
local: map[string]string{
"firefox": "~/.mozilla/native-messaging-hosts",
"chrome": "~/.config/google-chrome/NativeMessagingHosts",
"chromium": "~/.config/chromium/NativeMessagingHosts",
// "brave": "~/.config/BraveSoftware/Brave-Browser/NativeMessagingHosts",
// "vivaldi": "~/.config/vivaldi/NativeMessagingHosts",
"iridium": "~/.config/iridium/NativeMessagingHosts",
// "slimjet": "~/.config/slimjet/NativeMessagingHosts",
Comment on lines +8 to +11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the commented out browsers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no support for those browsers in FreeBSD

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case please just remove them.

},
global: map[string]string{
"firefox": "/usr/local/lib/mozilla/native-messaging-hosts",
"chrome": "/usr/local/lib/chrome/native-messaging-hosts",
"chromium": "/usr/local/lib/chromium/native-messaging-hosts",
// "brave": "/usr/local/lib/chrome/native-messaging-hosts",
// "vivaldi": "/usr/local/lib/vivaldi/native-messaging-hosts",
"iridium": "/usr/local/lib/iridium-browser/native-messaging-hosts",
// "slimjet": "/usr/local/lib/slimjet/native-messaging-hosts",
},
}
4 changes: 2 additions & 2 deletions internal/jsonapi/manifest/manifest_path_others.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//go:build !linux && !darwin
// +build !linux,!darwin
//go:build !linux && !darwin && !freebsd
// +build !linux,!darwin,!freebsd

package manifest

Expand Down
Loading