Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Process Draft Inline Images to send properly #171

Closed
wants to merge 2 commits into from
Closed

Process Draft Inline Images to send properly #171

wants to merge 2 commits into from

Conversation

tyochelson-lwhs
Copy link

Resolves Issue #163 -- handling of Inline Images varies between GmailDraft and GmailMessage classes; code changes convert attachments to inlineImages and update tags in HTML Body text to conform to updated usage.

Per Issue #163 -- handling of Inline Images varies between GmailDraft and GmailMessage classes; code changes convert attachments to inlineImages and update <img> tags in HTML Body text to conform to updated usage.
@google-cla
Copy link

google-cla bot commented Feb 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tyochelson-lwhs
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Feb 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tyochelson-lwhs
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Feb 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tyochelson-lwhs
Copy link
Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Feb 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Resolves Issue #163 -- handling of Inline Images varies between GmailDraft and GmailMessage classes; code changes convert attachments to inlineImages and update  tags in HTML Body text to conform to updated usage. Re-committing to associate my email address for CLA-foo.
@google-cla
Copy link

google-cla bot commented Feb 12, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@sqrrrl
Copy link
Member

sqrrrl commented Feb 17, 2021

Superseded by #173

@sqrrrl sqrrrl closed this Feb 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants