Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update caniuse-lite db to fix UMD build dependencies #548

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zackdotcomputer
Copy link
Contributor

This resolves the issue where the .umd.js build is including a reference to require("core-js...")

This appears to be because an unrelated update caused an update to the caniuse-lite repository which incorrectly informs babel that this library should be required rather than polyfilled. This issue was fixed in the latest release of that repository, so updating it in the lockfile fixes the underlying issue.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #528 🦕

@zackdotcomputer zackdotcomputer changed the title Update caniuse-lite db to fix UMD build dependencies fix: Update caniuse-lite db to fix UMD build dependencies May 6, 2024
@jpoehnelt jpoehnelt enabled auto-merge (squash) May 6, 2024 20:20
@jpoehnelt
Copy link
Collaborator

@wangela ptal

@zackdotcomputer
Copy link
Contributor Author

@wangela Are you available to take a look at this PR? It is blocking us from upgrading out Google Maps packages to latest.

@diego-santacruz
Copy link

diego-santacruz commented Jun 19, 2024

This is quite annoying in packages using @googlemaps/url-signature as dependency, can someone review this so that a new version can be released? See #528 for a lot of people waiting on this.

@zackdotcomputer
Copy link
Contributor Author

I just merged main into this branch to make sure this change was still needed. It is. Not sure if there is someone else who can review this inside of Google - it looks like the only PR activity for the last few weeks on this repo has been the google-bot automerging dependabot PRs.

auto-merge was automatically disabled August 2, 2024 10:07

Head branch was pushed to by a user without write access

@zackdotcomputer
Copy link
Contributor Author

It appears that this might not be necessary anymore because updates to Babel have caused a bump to the caniuse libraries that, while not to latest, have gotten the library out of the bad-zone.

@diego-santacruz
Copy link

@zackdotcomputer Thanks for noting that the issue has gone away.

I can confirm that I could remove the override I had added to stick with 1.0.32, with version 1.0.36 the problem is not present any longer.

I think this issue can thus be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants