Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the qa tool more robust #709

Merged
merged 5 commits into from
Sep 1, 2023
Merged

Make the qa tool more robust #709

merged 5 commits into from
Sep 1, 2023

Conversation

simoncozens
Copy link
Contributor

This improves the robustness of ghtools.qa in a couple of ways:

  • Ensures that the fontbakery report is posted as a GH comment just after fontbakery runs, so it is encapsulated from other methods.
  • Wraps each function in a decorator which catches exceptions so that an exception in one test does not crash the whole tool.
  • Posts a notification of any exceptions/failures to GH.

This is split into fairly small self-contained commits, so may be easiest to review one commit at a time.

Copy link
Member

@felipesanches felipesanches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. That's all looking great!

@simoncozens
Copy link
Contributor Author

Cool, thank you!

@simoncozens simoncozens merged commit e2f45d8 into main Sep 1, 2023
9 checks passed
@simoncozens simoncozens deleted the robust-qa branch September 1, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants