Provide UFO structure #705
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please hold on, that was unintentional, and Denis already fixed it in main. Let's push out a 3.7.1 first and use that one without passing the extra arg. |
anthrotype
reviewed
Aug 7, 2023
| @@ -389,6 +389,9 @@ def run_fontmake(self, source, args): | |||
| args["check_compatibility"] = self.config["checkCompatibility"] | |||
| if "glyphData" in self.config: | |||
| args["glyph_data"] = self.config["glyphData"] | |||
| # The following line should be removed once we require | |||
| # fontmake >= 3.7.1 | |||
| args["ufo_structure"] = "package" | |||
There was a problem hiding this comment.
ufo_structure parameter didn't exist before 3.7.0 so in practice passing this parameter is equivalent to requiring fontmake >= 3.7.0 (which you did not do in pyproject.toml's dependencies as far as I can tell).
It's probably better to do nothing and rely on the latest 3.7.1 to just fix the issue.
I can also "yank" 3.7.0 if you want (make it unavailable from pip install unless one explicitly requests fontmake==3.7.0), but maybe it's not worth it, it was online only a couple days
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fonttools v3.7.0 changed the API (thanks!) requiring an extra keyword argument to
run_from_glyphs. See googlefonts/googlefonts-project-template#109