Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop packager from deleting minisite_url from metadata.pb #699

Merged
merged 2 commits into from
Jul 28, 2023
Merged

stop packager from deleting minisite_url from metadata.pb #699

merged 2 commits into from
Jul 28, 2023

Conversation

RosaWagner
Copy link
Contributor

Saw same issue as in #693 so tried same technique

@RosaWagner RosaWagner requested a review from m4rc1e July 28, 2023 12:46
m4rc1e
m4rc1e approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@m4rc1e m4rc1e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this!

@m4rc1e m4rc1e merged commit caaf21b into googlefonts:main Jul 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4rc1e m4rc1e m4rc1e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RosaWagner @m4rc1e