fix: Wrong escape sequences #1007
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| @@ -3,4 +3,4 @@ | |||
|
|
|||
| class AutohintOTF(OperationBase): | |||
| description = "Run otfautohint" | |||
| rule = "otfautohint $args -o $out $in \|\| otfautohint $args -o $out $in --no-zones-stems" | |||
| rule = "otfautohint $args -o $out $in \\|\\| otfautohint $args -o $out $in --no-zones-stems" | |||
There was a problem hiding this comment.
@arrowtype's traceback shows,
otfautohint: error: argument -o/--output: /fonts/Familyname/|| is not a valid path to write to.
The or operator looks well escaped. The issue is that the or operator is attached to the filename. Perhaps quoting the $out and $in args will work e.g
'otfautohint $args -o "$out" "$in" \|\| otfautohint $args -o "$out" "$in" --no-zones-stems'
There was a problem hiding this comment.
You are right, probably the $in and $out arguments should be escaped with quotes. I will adjust that. The thing I encountered was actually a Python warning:
aragon999
force-pushed
the
fix/wrong-escape-sequences
branch
from
705f15f
to
7e3d72f
Compare
Maybe fixes #1004