[ttx_diff] Use pip-compile and requirements.in #1090
+343
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a more consistent way of ensuring we have pinned our python dependencies.
rsheeter
approved these changes
Nov 4, 2024
anthrotype
reviewed
Nov 5, 2024
| - `pip install -r resources/scripts/requirements.txt` | ||
| - `pip freeze > resources/scripts/constraints.txt` | ||
| - install pip-tools with `python -m pip install pip-tools` | ||
| - delete `resources/scripts/requirements.txt` |
There was a problem hiding this comment.
I don't think you need to delete it as it will be overwritten, but it's ok
anthrotype
reviewed
Nov 5, 2024
| python pacakges we are comparing against; to ensure this we use `pip-compile` | ||
| (part of [`pip-tools`]) to generate a pinned `requirements.txt` from a | ||
| `requirements.in` file in the root `resources/scripts` directory. To update the | ||
| set of python packages in use, you need to update this file: | ||
|
|
||
| - `rm -rf` your existing venv | ||
| - create a new venv and activate it |
There was a problem hiding this comment.
one doesn't need to delete and create a new venv when using pip-compile, it may well run from a global site-packages (e.g. I install it globally with pipx install pip-tools) as pip-compile does not modify its environment.
There was a problem hiding this comment.
installing something in a venv is generally good practice especially when developing onto something, in this case we are simply using a development tool and it's not a requirement that it runs within a venv, so I don't think you should mention this here
anthrotype
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a more consistent way of ensuring we have pinned our python dependencies.