Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reverting Release Please anontations for dependencies.properties #3398

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Nov 26, 2024

Reverts #3396

#3382 (comment)

I think my pull request about Release Please annotation broke the CI checks for Release Please pull request.

The Bazel integration tests are not ready to use the locally installed artifacts in local Maven repository. GAX artifacts are fine because they are from Bazel package. I'll need to explore how to build them in c8cb5ae#diff-8a0414289f48984fdac9f835e30a3c10f79ebef40088b9045c98665d2bddb6e3.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 26, 2024
@suztomo suztomo changed the title Revert "chore: Release Please anontations for dependencies.properties" chore: reverting Release Please anontations for dependencies.properties Nov 26, 2024
Copy link

sonarcloud bot commented Nov 26, 2024

Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@suztomo suztomo merged commit 6544539 into main Nov 26, 2024
49 checks passed
@suztomo suztomo deleted the revert-3396-i2428 branch November 26, 2024 16:57
lqiu96 pushed a commit that referenced this pull request Dec 3, 2024
…es (#3398)

Reverts #3396


#3382 (comment)

> I think my pull request about Release Please annotation broke the CI
checks for Release Please pull request.

The Bazel integration tests are not ready to use the locally installed
artifacts in local Maven repository. GAX artifacts are fine because they
are from Bazel package. I'll need to explore how to build them in
c8cb5ae#diff-8a0414289f48984fdac9f835e30a3c10f79ebef40088b9045c98665d2bddb6e3.
lqiu96 pushed a commit that referenced this pull request Dec 3, 2024
…es (#3398)

Reverts #3396


#3382 (comment)

> I think my pull request about Release Please annotation broke the CI
checks for Release Please pull request.

The Bazel integration tests are not ready to use the locally installed
artifacts in local Maven repository. GAX artifacts are fine because they
are from Bazel package. I'll need to explore how to build them in
c8cb5ae#diff-8a0414289f48984fdac9f835e30a3c10f79ebef40088b9045c98665d2bddb6e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants