-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid 403 from to_gbq when table has policyTags #356
Conversation
@@ -0,0 +1,95 @@ | |||
"""Module for checking dependency versions and supported features.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this out of gbq.py
, because load.py
also needs some of this logic now.
yield remaining_rows | ||
client.load_table_from_file( | ||
chunk_buffer, | ||
if FEATURES.bigquery_has_from_dataframe_with_csv: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not strictly necessary (just the "omit policyTags" logic was), but I thought this might be a good opportunity to use more logic from google-cloud-bigquery
, per #339
The CSV encoding in google-cloud-bigquery
is still relatively new, so I didn't want to bump our minimum google-cloud-bigquery
versions yet. Discussion: #357
conda-3.7 test failures:
The
|
Follow-up to googleapis/python-bigquery#557
nox -s blacken lint
docs/source/changelog.rst
entry