Skip to content

Commit

Permalink
Merge branch 'main' into mila/multiple-inequality
Browse files Browse the repository at this point in the history
  • Loading branch information
milaGGL authored Sep 1, 2023
2 parents db313e9 + f964634 commit 3ec9f5c
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 4 deletions.
9 changes: 9 additions & 0 deletions dev/src/reference.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1847,6 +1847,15 @@ export class Query<T = firestore.DocumentData> implements firestore.Query<T> {
return this._queryOptions.fieldOrders;
}

// TODO(b/296435819): Remove this warning message.
if (cursorValuesOrDocumentSnapshot[0] instanceof DocumentReference) {
// eslint-disable-next-line no-console
console.warn(
`Warning: Passing DocumentReference into a cursor without orderBy clause is not an intended
behavior. Please use DocumentSnapshot or add an explicit orderBy on document key field.`
);
}

const fieldOrders = this._queryOptions.fieldOrders.slice();
const fieldsNormalized = new Set([
...fieldOrders.map(item => item.field.toString()),
Expand Down
8 changes: 4 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
"fast-deep-equal": "^3.1.1",
"functional-red-black-tree": "^1.0.1",
"google-gax": "^3.5.7",
"protobufjs": "^7.0.0"
"protobufjs": "^7.2.5"
},
"devDependencies": {
"@types/assert": "^1.4.0",
Expand All @@ -82,12 +82,12 @@
"extend": "^3.0.2",
"gts": "^3.1.0",
"jsdoc": "^4.0.0",
"jsdoc-fresh": "^2.0.0",
"jsdoc-region-tag": "^2.0.0",
"jsdoc-fresh": "^3.0.0",
"jsdoc-region-tag": "^3.0.0",
"length-prefixed-json-stream": "^1.0.1",
"linkinator": "^5.0.0",
"mocha": "^9.2.2",
"protobufjs-cli": "^1.0.0",
"protobufjs-cli": "^1.1.2",
"proxyquire": "^2.1.3",
"sinon": "^15.0.0",
"through2": "^4.0.0",
Expand Down

0 comments on commit 3ec9f5c

Please sign in to comment.