feat: Add Metrics host for built in metrics #3519
Open
+50
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
surbhigarg92
force-pushed
the
metrics_endpoint
branch
from
5e6b39b
to
8ad2163
Compare
product-auto-label
bot
added
size: m
|
|
||
| @Override | ||
| public String getMetricsHost() { | ||
| return System.getenv(SPANNER_METRICS_HOST); |
There was a problem hiding this comment.
Can we make sure it returns DEFAULT MONITORING HOST if metrics host is empty? otherwise it's a breaking change since you are always asking customer for monitoring host.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to set the custom monitoring host for built in metrics.