Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing log for permanent error #1701

Closed

Conversation

maitrimangal
Copy link
Member

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1266 ☕️

@maitrimangal maitrimangal requested a review from a team as a code owner August 16, 2023 19:23
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/java-pubsub API. labels Aug 16, 2023
@maitrimangal maitrimangal changed the title removing log for permanent error fix: removing log for permanent error Aug 16, 2023
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@maitrimangal maitrimangal added the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2023
@maitrimangal maitrimangal added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 16, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner August 16, 2023 20:05
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Aug 16, 2023
Copy link
Contributor

@hannahrogers-google hannahrogers-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I understand why we are removing this log? I think we should instead try to understand why we are getting an Invalid response from the server.

@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 17, 2023
@maitrimangal
Copy link
Member Author

In the client library meeting, Kamal, Alex and I discussed that we should only be logging transient errors, and not permanent errors. Let me confirm with them if that is still the case then?

suztomo pushed a commit to suztomo/java-pubsub that referenced this pull request Oct 5, 2023
…pis#1701) (googleapis#1390)

* test: add presubmit to verify java_library requirements file

Source-Link: googleapis/synthtool@d148182
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:27d0a1232b3656f0610cc1a55beb157cb3b63b1ca8b3dfba0bcd8b9dfecda4a1

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Diego Alonso Marquez Palacios <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/java-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pubsub: Warning during acknowledgement message on subscription with enabled Exactly once delivery flag
2 participants