feat: introduce java.time (#1410)

* feat: introduce `java.time` * declare threeten as test-scoped * completely remove threeten * reset tests * fix ignore * fix dependency:analyze
googleapis · Nov 26, 2024 · 05b12ae · 05b12ae
1 parent 32b02a3
commit 05b12ae
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -155,6 +155,7 @@
     <dependency>
       <groupId>org.threeten</groupId>
       <artifactId>threetenbp</artifactId>
+      <scope>test</scope>
     </dependency>
   </dependencies>
 

diff --git a/src/main/java/com/google/cloud/logging/logback/LogbackBatchingSettings.java b/src/main/java/com/google/cloud/logging/logback/LogbackBatchingSettings.java
@@ -19,7 +19,7 @@
 import com.google.api.gax.batching.BatchingSettings;
 import com.google.api.gax.batching.FlowControlSettings;
 import com.google.api.gax.batching.FlowController.LimitExceededBehavior;
-import org.threeten.bp.Duration;
+import java.time.Duration;
 
 /**
  * This class is used only to provide batch settings configuration in logback.xml since {@link
@@ -69,7 +69,7 @@ public BatchingSettings build() {
       settings.setRequestByteThreshold(requestByteThreshold);
     }
     if (delayThreshold != null) {
-      settings.setDelayThreshold(Duration.ofMillis(delayThreshold));
+      settings.setDelayThresholdDuration(Duration.ofMillis(delayThreshold));
     }
     if (maxOutstandingElementCount != null
         || maxOutstandingRequestBytes != null