-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a basic E2E Client-side Tracing Test w/ Opentelemetry SDK and Cloud Trace Exporter #1607
Adding a basic E2E Client-side Tracing Test w/ Opentelemetry SDK and Cloud Trace Exporter #1607
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some nits pointed out below. And we should get the CI to go green.
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITE2ETracingTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITE2ETracingTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITE2ETracingTest.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITE2ETracingTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITE2ETracingTest.java
Outdated
Show resolved
Hide resolved
// TODO(jimit) Make it re-usable w/ InMemorySpanExporter | ||
traceExporter = | ||
TraceExporter.createWithConfiguration( | ||
TraceConfiguration.builder().setProjectId(PROJECT_ID).build()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean FirestoreOptions.getDefaultProjectId()
?
Abandoning PR. New PR at #1621. |
test: Basic test-case to ensure to verify end-to-end tracing is working using Otel SDK, Cloud Trace Exporter and Cloud Trace v1 API.
Fixes #1604 ☕️