Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a basic E2E Client-side Tracing Test w/ Opentelemetry SDK and Cloud Trace Exporter #1607

Conversation

jimit-j-shah
Copy link
Contributor

@jimit-j-shah jimit-j-shah commented Mar 12, 2024

test: Basic test-case to ensure to verify end-to-end tracing is working using Otel SDK, Cloud Trace Exporter and Cloud Trace v1 API.

Fixes #1604 ☕️

@jimit-j-shah jimit-j-shah self-assigned this Mar 12, 2024
@jimit-j-shah jimit-j-shah requested review from a team as code owners March 12, 2024 21:30
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: firestore Issues related to the googleapis/java-firestore API. labels Mar 12, 2024
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some nits pointed out below. And we should get the CI to go green.

@jimit-j-shah jimit-j-shah changed the base branch from ehsann/client-side-tracing-using-otel-2 to ehsann/tracing-6 March 14, 2024 22:36
@jimit-j-shah jimit-j-shah changed the base branch from ehsann/tracing-6 to ehsann/client-side-tracing-using-otel-2 March 14, 2024 22:36
google-cloud-firestore/pom.xml Show resolved Hide resolved
// TODO(jimit) Make it re-usable w/ InMemorySpanExporter
traceExporter =
TraceExporter.createWithConfiguration(
TraceConfiguration.builder().setProjectId(PROJECT_ID).build());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you should be able to remove PROJECT_ID usages in this file. You can use firestoreOptions.getProjectId() so that the two services (Firestore and CloudTrace) are used in the same gcp project. I think the CI picks that up from env vars here and here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean FirestoreOptions.getDefaultProjectId()?

@jimit-j-shah
Copy link
Contributor Author

Abandoning PR. New PR at #1621.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/java-firestore API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants