feat: add support for Row Affinity app profiles #2341
Conversation
Change-Id: I7cdd6c9ce85f9132c0fa3db3aa8c70abac26f12b
Change-Id: Id2cedefd90c52c249b2b15734eb1fbbcc5db2bf4
Change-Id: I01ef72617d391bdb956ae9f469f1fd5af208a2e1
Change-Id: I9f18991cb61d99f30b811cea0988963d9e2577cd
product-auto-label
bot
added
size: l
| @@ -267,6 +271,32 @@ public static MultiClusterRoutingPolicy of(Set<String> clusterIds) { | |||
| MultiClusterRoutingUseAny.newBuilder().addAllClusterIds(clusterIds).build()); | |||
| } | |||
|
|
|||
| /** Creates a new instance of {@link MultiClusterRoutingPolicy}. */ | |||
| public static MultiClusterRoutingPolicy ofWithRowAffinity() { | |||
There was a problem hiding this comment.
I think withRowAffinity is a bit less akward
There was a problem hiding this comment.
Also can you describe what the difference between this variant and withRowAffinity(String... clusterIds)
There was a problem hiding this comment.
Also is it possible to update an app profile to change cluster ids? or to change the routing away from row affinity?
There was a problem hiding this comment.
Also do you need to update the mask?
There was a problem hiding this comment.
Also can you describe what the difference between this variant and withRowAffinity(String... clusterIds)
Yes - Row affinity, when enabled, routes single row key requests deterministically to the same cluster each time to improve read-your-writes consistency.
When row affinity is enabled with a cluster group (with cluster IDs specified), then when the user adds a new cluster to their instance, it does not affect which clusters each row key routes to. It is a way to protect read-your-writes consistency from being impacted negatively from new clusters as well as from attempts to delete clusters (since you cannot delete a cluster if its in the cluster group). Without the cluster group, when a user adds a new cluster, row keys will undergo a shuffling of which cluster they route to, which temporarily breaks read-your-writes consistency.
There was a problem hiding this comment.
Also do you need to update the mask?
I don't think so, but correct me if I am wrong: row affinity is a subfield/submessage of MultiClusterRoutingUseAny (routing policy), and we already have existing methods for updating the routing policy with the appropriate mask: https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/models/UpdateAppProfileRequest.java#L106-L125
Also is it possible to update an app profile to change cluster ids? or to change the routing away from row affinity?
It should be possible to do both of these. The user should call UpdateAppProfileRequest::SetRoutingPolicy and supply a routing policy with new cluster ids or with row affinity absent
Change-Id: I9f88209e04cde4f628c878fbdb659c7344aa1c3c
…to feature-affinity-proto Change-Id: I3fae97fa5283129ae449d0f6bbc8f2ee6fc2601d
| adminClient.createAppProfile( | ||
| CreateAppProfileRequest.of(INSTANCE_ID, APP_PROFILE_ID) | ||
| .setDescription("my description") | ||
| .setRoutingPolicy(MultiClusterRoutingPolicy.withRowAffinity("cluster-id-1", "cluster-id-2"))); |
There was a problem hiding this comment.
Is this the same as the test above?
There was a problem hiding this comment.
It is similar. The one above adds the cluster_ids one at a time via "addClusterIds". This test adds all the cluster_ids in one list via "addAllClusterIds"
There was a problem hiding this comment.
I think that's testing the generated proto instead of testing our wrapper class. We can probably just keep one of the 2 test.
There was a problem hiding this comment.
Okie - removed this one.
Change-Id: Ieda39f0d9825fae649755350b4f228fe0e8985e5
Change-Id: I6d8e7bd644ce2cd8f098c8ee37b4eec1a0d642e2
|
/gcbrun |
yoshi-kokoro
removed
the
kokoro:run
Change-Id: I7b072214c8b38646058d0ec668bbb469bf16f23e
yoshi-kokoro
removed
the
kokoro:run
Change-Id: Ieb04b2141c8843ff59cc4d756d736b4c00609ee2
yoshi-kokoro
removed
the
kokoro:run
|
/gcbrun |
mutianf
added
the
do not merge
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.