Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(bigtable): fix conformance tests #26510

Merged
merged 1 commit into from
Jul 22, 2024
Merged

chore(bigtable): fix conformance tests #26510

merged 1 commit into from
Jul 22, 2024

Conversation

dazuma
Copy link
Member

@dazuma dazuma commented Jul 22, 2024 •
edited
Loading

Several fixes to get BigTable conformance tests working again:

  • Updates the conformance test proto classes to conform to protobuf 4.x (i.e. no DSL) by regenerating them with the latest proto compiler. Also related:
    • Implements toys conformance gen-protos which can be used to regenerate this file again in the future.
    • Moves a few of those files to make regeneration easier
  • Fixes the test proxy so it doesn't crash on CreateClient calls that omit some optional parameters.
  • Updates the test proxy Gemfile to require the latest versions of grpc gems.

Should fix the tests in #26494.

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 22, 2024
@dazuma dazuma marked this pull request as draft July 22, 2024 22:25
@dazuma dazuma force-pushed the pr/bigtable-conformance branch 4 times, most recently from ed4eb6b to e926c4b Compare July 22, 2024 22:53
@dazuma dazuma marked this pull request as ready for review July 22, 2024 23:05
@dazuma dazuma requested a review from aandreassa July 22, 2024 23:08
@dazuma dazuma force-pushed the pr/bigtable-conformance branch from e926c4b to 6bffe0b Compare July 22, 2024 23:10
aandreassa
aandreassa approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@aandreassa aandreassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dazuma dazuma merged commit 1da94df into googleapis:main Jul 22, 2024
17 checks passed
@dazuma dazuma deleted the pr/bigtable-conformance branch July 22, 2024 23:43
@aandreassa aandreassa mentioned this pull request Aug 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aandreassa aandreassa aandreassa approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dazuma @aandreassa