Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl(GCS+gRPC): export metrics with desired monitored resource #14270

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

coryan
Copy link
Member

@coryan coryan commented May 21, 2024

Fixes #13998


This change is Reviewable

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.59%. Comparing base (e353a33) to head (a1e9b19).

Files Patch % Lines
.../storage/internal/grpc/metrics_exporter_options.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14270   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files        2315     2315           
  Lines      207140   207126   -14     
=======================================
- Hits       193869   193858   -11     
+ Misses      13271    13268    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from c16d4d8 to a55d4d0 Compare May 22, 2024 14:52
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from a55d4d0 to 64a1d1b Compare May 23, 2024 13:04
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from 64a1d1b to 464cc76 Compare June 25, 2024 12:35
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from 464cc76 to ca3e8ef Compare June 27, 2024 18:11
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from ca3e8ef to 7e4224d Compare June 27, 2024 19:32
@coryan coryan force-pushed the impl-GCS+gRPC-always-enable-gRPC-metrics-pr7 branch from 7e4224d to a1e9b19 Compare July 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create helpers to initialize and export gRPC metrics
1 participant