Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: supply proper location for GitHub Action format #1081

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: supply proper location for GitHub Action format #1081

wants to merge 3 commits into from

Commits on Jun 14, 2023

  1. feat: Expose lint.FileLocationFromPBLocation 

    Make the internal method lint.FileLocationFromPBLocation public so that
formatters beyond the YAML and JSON marshal methods can rely on the same
logic to translate protobuf Spans into useable file locations.
    James Socol committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    23037bb View commit details
    Browse the repository at this point in the history

  2. fix(googleapisgh-1071): Fix file location in github output 

    Use the lint.FileLocationFromPBLocation method to get the correct
problem locations for the GitHub Actions formatter, rather than
re-implementing the conversion from PB location to file location.
    James Socol committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    5a64cb4 View commit details
    Browse the repository at this point in the history

  3. Fix bug from rebase

    James Socol committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    4ea63a6 View commit details
    Browse the repository at this point in the history