-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add details on how to run generated code #363
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the title of commit message, please fix, s/to to/how to
@jayzhuang i have changed the commit msg |
LGTM |
+@stytchiz who have write access |
Thanks @jayzhuang :) |
Fixes #362
Added some details on how to run the generated code. I was having a bad time following the tutorial since I kept getting the error:
when following the tutorial since I ran it with
go run main.go
usinggo1.18.3
. It's not obvious to me that we need to includewire_gen.go
to make it work.