pkg/manager: show number of times coverage for each call has overflowed #5520
+133
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-nogikh
previously approved these changes
Nov 19, 2024
dvyukov
force-pushed
the
dvyukov-cover-overflow
branch
2 times, most recently
from
78e12c0
to
f5cd48a
Compare
dvyukov
force-pushed
the
dvyukov-cover-overflow
branch
3 times, most recently
from
a0d26dd
to
b24d78f
Compare
a-nogikh
previously approved these changes
Nov 20, 2024
If the overflows happen often, it's bad. Add visibility into this.
The coverage buffer frequently overflows. We cannot increase it radically b/c they consume lots of memory (num procs x num kcovs x buffer size) and lead to OOM kills (at least with 8 procs and 2GB KASAN VM). So increase it 2x and slightly reduce number of threads/kcov descriptors. However, in snapshot mode we can be more aggressive (only 1 proc). This reduces number of overflows by ~~2-4x depending on syscall.
dvyukov
force-pushed
the
dvyukov-cover-overflow
branch
from
b24d78f
to
08f0c64
Compare
a-nogikh
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the overflows happen often, it's bad.
Add visibility into this.