syz-declextract: support nested netlink policies #5514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dvyukov
commented
Nov 15, 2024
dvyukov
commented
- pkg/compiler: allow recursion via arrays
- sys/linux: remove nl_generic_attr_nonested hack
- tools/syz-declextract: don't generate NLA_REJECT/TYPE_MAX attrs
- tools/syz-declextract: support nested netlink policies
dvyukov
changed the title
tarasmadan
previously approved these changes
Nov 15, 2024
dvyukov
force-pushed
the
dvyukov-declextract-more4
branch
from
ebc7ac3
to
281d8e2
Compare
Permit structs to recursively contain itself in arrays. This is needed for netlink. Amusingly several netlink policies contain itself.
It was needed to work around restriction on recursion via arrays. Since we permit it now, we can remove the hack.
These are not accepted as inputs (NLA_REJECT is usually used in dump operation).
dvyukov
force-pushed
the
dvyukov-declextract-more4
branch
from
281d8e2
to
9c363f3
Compare
tarasmadan
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.