Added new experimental data #23
Conversation
hung-chi
commented
Nov 1, 2022
hung-chi
commented
- Tests pass
- Appropriate changes to README are included in PR
Signed-off-by: hung-chi <[email protected]>
Signed-off-by: hung-chi <[email protected]>
|
@hung-chi Can you add the notebook you showed me last Friday? |
You can find the notebook at https://github.com/hung-chi/skywater-pdk-sky130-raw-data/blob/develop/notebooks/electrical_characterization_sky130_epfl.ipynb |
|
@hung-chi - Is that notebooks part of this pull request? |
Yes, the notebook is included. You could find it in my forked repo at https://github.com/hung-chi/skywater-pdk-sky130-raw-data/blob/develop/notebooks/electrical_characterization_sky130_epfl.ipynb |
|
I added the Gm/ID plot. You can find them in the updated notebook. |
README.rst
Outdated
| @@ -10,6 +10,9 @@ Experimental Data | |||
|
|
|||
| The experimental data in this repository is currently stored in the `.mdm` file format. | |||
|
|
|||
| **Other data** | |||
|
|
|||
| * (2022-Nov-1) New experimental data by EPFL is stored in the `.csv` format at `sky130_fd_pr/epfl <./sky130_fd_pr/epfl>`_. The corresponded notebook can be found at `notebooks/electrical_characterization_sky130_epfl.ipynb <./notebooks/electrical_characterization_sky130_epfl.ipynb>`_. | |||
There was a problem hiding this comment.
maybe move the data under a different top level dirrectory for consistency?
sky130_fd_pr_epfl/cells
@mithro any input there?
| @@ -0,0 +1,1204 @@ | |||
| { | |||
| "cells": [ | |||
There was a problem hiding this comment.
can we add a new cell with a colab badge:
+ {
+ "cell_type": "markdown",
+ "metadata": {
+ "id": "view-in-github",
+ "colab_type": "text"
+ },
+ "source": [
+ "<a href=\"https://colab.research.google.com/github/proppy/skywater-pdk-sky130-raw-data/blob/develop/notebooks/electrical_characterization_sky130_epfl.ipynb\" target=\"_parent\"><img src=\"https://colab.research.google.com/assets/colab-badge.svg\" alt=\"Open In Colab\"/></a>"
+ ]
+ },
and another one that clone the repo, similar to what we have for the other notebooks:
https://github.com/google/skywater-pdk-sky130-raw-data/blob/main/notebooks/sky130_plot_gm.ipynb
https://github.com/google/skywater-pdk-sky130-raw-data/blob/main/notebooks/sky130_plot_current.ipynb
also maybe rename it to have s similar naming scheme as the other one?
@bmurmann should we look into consolidating with your existing notebook and allow it to work across multiple dataset?
There was a problem hiding this comment.
My notebook is very simple, best to build on this new one instead of consolidating/merging.
|
@hung-chi thanks for working on this! Do you think it would it makes sense to modify the notebook so that they can be opened in https://colab.research.google.com/ ? If you agree, maybe we can do the follow-up changes (either in this PR or separatly):
|
Sure, I can do that in the PR. Also fine with inlining the utils in |
1. included in-line utils 2. included colab 3. included copyright and license 4. included git clone
|
Hi @proppy I have updated the notebook by including the self-clone, in-line utils, colab. Thanks |
| } | ||
| }, | ||
| "source": [ | ||
| "<h1>Electrical characterization of SkyWater 130 nm<span class=\"tocSkip\"></span></h1>\n", |
There was a problem hiding this comment.
can you add the colab badge here too?
| "outputs": [], | ||
| "source": [ | ||
| "import pandas as pd\n", | ||
| "import sekve\n", |
There was a problem hiding this comment.
I think you may need a few %pip install command before you can import this.
| "import re\n", | ||
| "import os\n", | ||
| "import os.path as op\n", | ||
| "import sekve\n", |
There was a problem hiding this comment.
I think you may need a few %pip install command before you can import this.
