Changes Reflecting BAG3 Open Sourcing Updates #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3_pr into google_pull
mithro
reviewed
May 8, 2023
|
The copyright headers should be fixed now, please let me know if there are other issues. |
mithro
reviewed
May 9, 2023
OA/BAG_prim/cdsinfo.tag
Outdated
| @@ -1,13 +1,17 @@ | |||
| # Copyright 2019-2021 SkyWater PDK Authors | |||
There was a problem hiding this comment.
This file is still be weirdly modified.
mithro
reviewed
May 9, 2023
| @@ -1,30 +1,66 @@ | |||
| # BAG (BAG AMS Generator) Primitives Library for [SKY130](https://github.com/google/skywater-pdk) | |||
mithro
reviewed
May 9, 2023
|
|
||
| This repository contains the required primitives to use the BAG3 framework with |
There was a problem hiding this comment.
Could we keep this description?
mithro
reviewed
May 9, 2023
install.sh
Outdated
| @@ -31,19 +33,14 @@ cp_files=( ".cdsenv.personal" | |||
| ln_files=( "bag_config.yaml" | |||
| ".cdsenv" | |||
| ".cdsinit" | |||
| ".simrc" | |||
| ".simrc" | |||
mithro
reviewed
May 9, 2023
install.sh
Outdated
| @@ -18,6 +19,7 @@ | |||
| # https://github.com/google/skywater-pdk-libs-sky130_bag3_pr/blob/master/LICENSE.alternative | |||
| # | |||
| # SPDX-License-Identifier: BSD-3-Clause OR Apache 2.0 | |||
| #!/usr/bin/env bash | |||
mithro
reviewed
May 9, 2023
install.sh
Outdated
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env bash | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Can we keep the hashbang as previous?
mithro
suggested changes
May 9, 2023
There was a problem hiding this comment.
Getting pretty close. There are still some fixes needed.
- The README.md needs to keep the old content. Your new additions are fine though.
- A few files have been slightly mangled when fixing the copyright header.
- Duplicate
# -*- coding: utf-8 -*-lines (needs to be the second line in the file). - Some files still missing copyright headers.
|
Sorry for the slow turnaround. I fixed:
|
mithro
added a commit
to mithro/skywater-pdk-libs-sky130_bag3_pr
that referenced
this pull request
May 15, 2023
Changes Reflecting BAG3 Open Sourcing Updates.
This was referenced May 15, 2023
|
@FeliciaG - I have merged this pull request but there are a couple of issues I identified, see |
|
@FeliciaG - I also invited you to this repository so that these issues can be assigned to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes have been made to reflect updates used in June 2022 and December 2022 tapeouts. This update is compatible with the newly released BAG3++, which is has a completely publicly available codebase.