Run pipenv verify before sync
#2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpollock
approved these changes
Jul 23, 2024
| @@ -40,7 +40,7 @@ jobs: | |||
| - name: Install pipenv | |||
| run: pip install pipenv==2023.12.1 | |||
| - name: Set up pipenv | |||
| run: pipenv sync --dev | |||
| run: pipenv verify && pipenv sync --dev | |||
There was a problem hiding this comment.
I'm unsure if the && here will result in pipenv sync silently not being run if the verify fails?
There was a problem hiding this comment.
I'm not 100% sure, but I assumed if pipenv verify fails here the whole workflow will fail, similar to the Makefile.
| @@ -16,7 +16,7 @@ ifeq "$(USE_POETRY)" "true" | |||
| install-cmd := poetry install | |||
| run-cmd := poetry run | |||
| else | |||
| install-cmd := pipenv sync | |||
| install-cmd := pipenv verify && pipenv sync | |||
There was a problem hiding this comment.
I'm unsure if the && here will result in pipenv sync silently not being run if the verify fails?
There was a problem hiding this comment.
The make command prints and errors if the verify fails:
...
Pipfile.lock is out-of-date. Run $ pipenv lock to update.
make: *** [Makefile:64: run-api-server] Error 1
Which seems reasonable to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipenv doesn't automatically check if the
Pipfilematches thePipfile.lockwhen runningpipenv sync. Addedpipenv verifycommands in all the places to do the manifest/lockfile verification. This should prevent things like #2379 from passing our tests.Poetry seems to automatically do this validation when you run
poetry install(But there is apoetry checkcommand as well?)