fix(maven): do not track registries when fetching requirements #1466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1447
When fetching requirements of a Maven dependency, we should not keep track of the registries defined in pom.xml of dependencies. Doing that will add a lot irrelevant registries to the client and sends unnecessary requests, and finally slows down the resolution.
This PR also disables
PreFetch
in Maven transitive scanning.PreFetch
callsMatchVersions
which sends requests tomaven-metadata.xml
for native Maven client.maven-metadata.xml
is not necessarily needed for all dependencies. DisablingPreFetch
will save us from making requests to these files. However, callingPreFetch
should be fine for deps.dev client, and this can be a TODO in the future.With this fix, resolving pom.xml is now shortened to 10-20 seconds.