feat(guided remediation): non-interactive JSON output format #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1437 +/- ##
==========================================
- Coverage 69.58% 67.17% -2.42%
==========================================
Files 186 193 +7
Lines 18354 18287 -67
==========================================
- Hits 12772 12284 -488
- Misses 4890 5348 +458
+ Partials 692 655 -37 ☔ View full report in Codecov by Sentry. |
michaelkedar
changed the title
cuixq
approved these changes
Dec 17, 2024
cmd/osv-scanner/fix/output.go
Outdated
There was a problem hiding this comment.
can you add documentation to these newly defined structs?
There was a problem hiding this comment.
documentation added
oliverchang
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1213
Adds
--formatflag toosv-scanner fix --non-interactiveto choose between oldtextand newjsonformat, which provides a more machine-readable description of the changes made by guided remediation. Thetextformat should remain unchanged.Also, renamed the
relockstrategy torelax(though maintained backwards-compatibility) to be a bit less ambiguous.There are a few things that'll need to change with osv-scanner v2. In particular, the way the reporter interface is being used. I'll need to revisit this when those are refactored.