Skip to content

Commit

Permalink
chore(github-actions): use non-snap version of firefox
Browse files Browse the repository at this point in the history
Per karma-runner/karma-firefox-launcher#183,
the snap version of firefox does not work with Karma.
jbms committed Nov 28, 2022
1 parent c23b7cb commit 9120dc1
Showing 1 changed file with 25 additions and 3 deletions.
28 changes: 25 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -32,7 +32,18 @@ jobs:
run: npm run build-module --no-typecheck
- name: Build Python client bundles
run: npm run build-python --no-typecheck
- run: sudo apt-get install firefox xvfb
- run: |
sudo add-apt-repository ppa:mozillateam/ppa
echo '
Package: *
Pin: release o=LP-PPA-mozillateam
Pin-Priority: 1001
Package: firefox
Pin: version 1:1snap1-0ubuntu2
Pin-Priority: -1
' | sudo tee /etc/apt/preferences.d/mozilla-firefox
sudo apt-get install firefox xvfb
if: startsWith(runner.os, 'Linux')
- name: Run JavaScript tests (including WebGL)
# Swiftshader, used by Chrome headless, crashes when running Neuroglancer
@@ -99,8 +110,19 @@ jobs:
- run: npm run build-python -- --no-typecheck
- name: Install Python packaging/test tools
run: python -m pip install --upgrade pip tox wheel numpy pytest
- run: sudo apt-get install -y firefox xvfb
if: ${{ startsWith(runner.os, 'Linux') }}
- run: |
sudo add-apt-repository ppa:mozillateam/ppa
echo '
Package: *
Pin: release o=LP-PPA-mozillateam
Pin-Priority: 1001
Package: firefox
Pin: version 1:1snap1-0ubuntu2
Pin-Priority: -1
' | sudo tee /etc/apt/preferences.d/mozilla-firefox
sudo apt-get install firefox xvfb
if: startsWith(runner.os, 'Linux')
- name: Test with tox
run: tox -e ${{ fromJSON('["skip-browser-tests","firefox-xvfb"]')[runner.os == 'Linux'] }}
env:

0 comments on commit 9120dc1

Please sign in to comment.