Add AutoHoG JSON importer #756
Conversation
j2kun
force-pushed
the
autohog-importer
branch
3 times, most recently
from
eca7a44
to
fee9014
Compare
|
Still TODO: convert ports from object to array |
|
This one should be ready for a final review now. |
| const rapidjson::Value &portData = itr->value; | ||
| assert(portData.IsObject() && | ||
| "Expected 'connections[...]' to be an object"); | ||
| const char *connectedPortName = portData["port"].GetString(); |
There was a problem hiding this comment.
I don't really understand why this value is always needed - in toposort.json the AND cell's port $0$ connection contains both cell and port -
"$0$": {
"cell": "input_cell",
"port": "$2$"
},
Shouldn't it either be connected to a port or a cell? Why does this field have both? It's also confusing because that port name is the same name as a local port name...
There was a problem hiding this comment.
I feel the names are also confusing, but the way I understand it is that port refers to one of:
- Global circuit input/output (when
cellis not present) - Local cell input/output (when
cellis present)
The problem is that $2$ is used many times in the example JSON, in each cell that has at least three inputs. So the way to disambiguate is either to give everything unique names, or add the name of the cell as a sort of namespace for the ports local to that cell.
asraa
added
the
pull_ready
Fixes #686