Extend test for OSGi manifest attributes #2738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Perform more extensive tests on generated OSGi attributes in
MANIFEST.MF
Description
The test is converted to a Maven Failsafe integration test (
...IT.java
) to run on the final JAR, and additionally performs more assertions on the attributes.However, there are the following disadvantages:
...IT.java
is confusing, compared to the regular...Test.java
However, the test tries to detect this and produce helpful assertion failures in that case.
mvn clean ...
due to [bnd-maven-plugin] Runningbnd-process
withoutmvn clean
causes different behavior bndtools/bnd#6221(on the other hand this is maybe an advantage since this would probably also fail the release when for some reason
clean
is not performed, and theMANIFEST.MF
would contain unexpected / not-reproducible content)Therefore, I would not mind if you reject this pull request if you think there are too many disadvantages with this or if you think the new test is too complex or too difficult to maintain.
Checklist
This is automatically checked by
mvn verify
, but can also be checked on its own usingmvn spotless:check
.Style violations can be fixed using
mvn spotless:apply
; this can be done in a separate commit to verify that it did not cause undesired changes.null
@since $next-version$
(
$next-version$
is a special placeholder which is automatically replaced during release)TestCase
)mvn clean verify javadoc:jar
passes without errors