Remove AccessController usage for enum adapter
#2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SecurityManager and AccessController are marked as deprecated for removal in the latest JDK versions, see https://openjdk.org/jeps/411. Additionally this code was originally added providently but it is not clear if or how many users actually depend on it.
eamonnmcmanus
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #2686
Description
See #2686 and the discussion there
This pull request removes the
AccessControllerusage, assuming most users don't depend on it and because it has been marked for removal in the JDK.Also adds a new test for serialization of a JDK enum class to make sure the adapter works correctly despite strong encapsulation of JDK internals (JEP 403).
Though the test is not directly related to the
AccessControllerremoval.