Fix API compatibility workflow failing when building previous version #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow is currently failing for the jpms-test module: > Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project jpms-test: > Fatal error compiling: error: bad value for --module-version option: 'JAPICMP-OLD' Therefore this commit changes the dummy version number format.
|
Thanks! It seems like the API compatibility workflow is not failing with this PR. Not sure if you want to update the description. |
|
Oh you are right; I forgot to consider that since this changes the workflow, it applies directly (and not delayed only on the next pull request). |
eamonnmcmanus
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes the current API compatibility workflows failures
Description
The workflow is currently failing for the jpms-test module:
Therefore this pull request changes the dummy version number format, so that it is not rejected anymore.