Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Error Prone warning suppressions #2497

Conversation

Marcono1234
Copy link
Collaborator

Purpose

The latest Error Prone version fixed a bug which makes these suppressions obsolete.

Checklist

  • New code follows the Google Java Style Guide
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

The latest Error Prone version fixed a bug which makes these
suppressions obsolete.
@eamonnmcmanus
Copy link
Member

Thanks!

@eamonnmcmanus eamonnmcmanus merged commit ff401f1 into google:main Sep 23, 2023
9 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/remove-error-prone-suppressions branch September 23, 2023 15:36
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Sep 14, 2024
The latest Error Prone version fixed a bug which makes these
suppressions obsolete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants