Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos and improve Gson Design Document formatting #2491

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix typos and improve Gson Design Document formatting #2491

merged 2 commits into from
Sep 20, 2023

Conversation

Marcono1234
Copy link
Collaborator

Purpose

Fixes some typos and grammar issues and tries to improve the Gson Design Document formatting.

Checklist

  • New code follows the Google Java Style Guide
  • If necessary, new public API validates arguments, for example rejects null
  • New public API has Javadoc
    • Javadoc uses @since $next-version$
      ($next-version$ is a special placeholder which is automatically replaced during release)
  • If necessary, new unit tests have been added
    • Assertions in unit tests use Truth, see existing tests
    • No JUnit 3 features are used (such as extending class TestCase)
    • If this pull request fixes a bug, a new test was added for a situation which failed previously and is now fixed
  • mvn clean verify javadoc:jar passes without errors

Marcono1234
Marcono1234 commented Sep 20, 2023
View reviewed changes
GsonDesignDocument.md
Copy link
Collaborator Author

@Marcono1234 Marcono1234 Sep 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed some redundant trailing whitespace in this file. Unfortunately due to that the GitHub diff UI fails to properly show the changes.

When reviewing the changes in this file, please temporarily configure your Git client or the GitHub UI to ignore whitespace changes.

Or should I revert the whitespace changes?

eamonnmcmanus
eamonnmcmanus approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine. Thanks!

@eamonnmcmanus eamonnmcmanus merged commit e93fda9 into google:main Sep 20, 2023
9 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/typos-formatting branch September 20, 2023 22:57
tibor-universe pushed a commit to getuniverse/gson that referenced this pull request Sep 14, 2024
@Marcono1234 @tibor-universe
Fix typos and improve Gson Design Document formatting (google#2491)
efe4d75 
* Fix typos and grammar issues

Most of them were found by IntelliJ

* Improve formatting and fix typos in Gson Design Document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcono1234 @eamonnmcmanus